Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TS + cdn url #1445

Closed
wants to merge 1 commit into from
Closed

chore: update TS + cdn url #1445

wants to merge 1 commit into from

Conversation

bautistaaa
Copy link
Member

@bautistaaa bautistaaa commented May 15, 2024

Description

Related Issue

Closes #1443

Motivation and Context

How Has This Been Tested?

Screenshots/Video (if applicable):

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typehero ❌ Failed (Inspect) May 15, 2024 9:49pm
typehero-admin ❌ Failed (Inspect) May 15, 2024 9:49pm
typehero-admin-staging ❌ Failed (Inspect) May 15, 2024 9:49pm
typehero-auth ❌ Failed (Inspect) May 15, 2024 9:49pm
typehero-og-image ❌ Failed (Inspect) May 15, 2024 9:49pm
typehero-web-staging ❌ Failed (Inspect) May 15, 2024 9:49pm

@bautistaaa
Copy link
Member Author

bautistaaa commented May 15, 2024

wtf is this pnpm issue

CleanShot 2024-05-15 at 14 31 55@2x

Copy link
Contributor

E2E report: https://166b0170.typehero-70p.pages.dev

@bautistaaa bautistaaa changed the title chore: update TS + cdn url + pnpm version chore: update TS + cdn url May 15, 2024
@bautistaaa
Copy link
Member Author

wtf is this pnpm issue

CleanShot 2024-05-15 at 14 31 55@2x

yeah idk ill revert the upgrade for now

@@ -4,10 +4,10 @@ import path from 'node:path';
import fetch from 'node-fetch';

/** @link https://typescript.azureedge.net/indexes/releases.json */
const TYPESCRIPT_VERSION = '5.3.3';
const TYPESCRIPT_VERSION = '5.4.5';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see the vercel build failed, could we only do one change at a time?

Suggested change
const TYPESCRIPT_VERSION = '5.4.5';
const TYPESCRIPT_VERSION = '5.3.3';

would require you to rerun the script

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh fine ill just make this a url change

@bautistaaa bautistaaa closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript CDN domain migration
2 participants