Tweak trampoline function to accept DataCon closures #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oblem with lens-aeson support (eta-hackage typelead#120)
|
|
|
This looks great. Thanks for reporting and fixing it, @mmisamore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with lens-aeson support (eta-hackage #120)
Description
Ensure the trampoline function permits DataCons as well as Thunks. This seems to permit lens libraries such as lens-aeson to function properly.
How Has This Been Tested?
./runtests.sh is passing all tests except arr003, which was failing before this change. I also reproduced the issue in eta-hackage (#120) and verified that this change resolved it.
Types of changes
Checklist: