Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dhall 1.23 #102

Merged
merged 2 commits into from
May 15, 2019
Merged

Dhall 1.23 #102

merged 2 commits into from
May 15, 2019

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented May 14, 2019

  • Use last dhall-to-etlas version (1.4.0.0) which uses dhall-1.23.0
  • Breaking change: the empty union cases must not aplly to an empty record, so:
let defaultLang = Some (types.Languages.Haskell2010 {=})

must be

let defaultLang = Some types.Languages.Haskell2010

@jneira jneira requested a review from rahulmutt May 14, 2019 08:03
@jneira jneira mentioned this pull request May 14, 2019
Open
5 tasks
rahulmutt
rahulmutt approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@rahulmutt rahulmutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jneira! Can you submit a follow-up PR to the main eta repo and adjust the stack.yaml accordingly?

@rahulmutt rahulmutt merged commit bbd7c55 into typelead:master May 15, 2019
@jneira jneira deleted the dhall-1.23 branch May 15, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulmutt rahulmutt rahulmutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneira @rahulmutt