Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Change CrossVersion.full to use CrossVersion.patch for Typelevel Scala compatibility. #202

Merged
merged 2 commits into from
Feb 24, 2017

Conversation

ClydeMachine
Copy link
Contributor

@ClydeMachine ClydeMachine commented Feb 22, 2017

Including text from the issue at typelevel/scala#135:

To use Typelevel Scala versions which are not exactly aligned with the corresponding Lightbend Scala version (ie. because they include an additional -bin-patch-nnn suffix in their version) we need to modify project builds which use CrossVersion.full (which includes the suffix) to use CrossVersion.patch (which doesn't) where appropriate (eg. for macro-paradise and other compiler plugins).

Replaced the aforementioned, as well as updating the use of "org.scala-lang" to scalaOrganization.value in library dependencies.

@codecov-io
Copy link

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          37       37           
  Lines         776      776           
  Branches       58       58           
=======================================
  Hits          572      572           
  Misses        204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1b4b3...43f1e0b. Read the comment docs.

@johnynek
Copy link
Contributor

👍

@tixxit tixxit merged commit b4114f6 into typelevel:master Feb 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants