Port align instance for IO and SyncIO from CE2 #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
requested changes
Mar 13, 2021
| @@ -1227,6 +1230,22 @@ object IO extends IOCompanionPlatform with IOLowPriorityImplicits { | |||
| a.handleErrorWith(_ => b) | |||
| } | |||
|
|
|||
| implicit val alignForIO: Align[IO] = | |||
There was a problem hiding this comment.
It's worth following the pattern we have elsewhere: define alignForIO to be a def which delegates to private[this] val _alignForIO. I realize it's a bit arcane, but this actually produces performance benefits because it avoids the memory barriers associated with val on object.
There was a problem hiding this comment.
Ok, I'll switch to this implementation then.
Thanks for the tip :)
| implicit val alignForIO: Align[IO] = | ||
| new IOAlign | ||
|
|
||
| protected class IOAlign extends Align[IO] { |
There was a problem hiding this comment.
While adding alignForIO I've used semigroupKForIO as a reference. Didn't really thought it through when choosing the access specifier.
Comment on lines
501
to
504
| implicit val alignForIO: Align[SyncIO] = | ||
| new SyncIOAlign | ||
|
|
||
| protected class SyncIOAlign extends Align[SyncIO] { |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1726