Fix unclear SBT example in documentation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
reviewed
Nov 5, 2020
There was a problem hiding this comment.
@stephenjudkins Thanks for this!
Technically this is not a typo, this how one would add it as a scala.js dep or cross building. Maybe we could reword this a bit so we could fit both?
// use this snippet for the JVM
libraryDependencies += "org.typelevel" %% "cats-parse" % "0.0.1"
// use this snippet for JS, or cross-building
libraryDependencies += "org.typelevel" %%% "cats-parse" % "0.0.1" |
|
Yeah, I'm not certain what the right way would be here, but I would personally err on just using |
|
@stephenjudkins do you want to update the PR with @regadas suggestion? I agree it would be helpful for people less familar with these sbt esoterica. |
stephenjudkins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.