Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semigroup instance for Ior #1354

Merged
merged 3 commits into from
Sep 5, 2016
Merged

Add semigroup instance for Ior #1354

merged 3 commits into from
Sep 5, 2016

Conversation

Fristi
Copy link
Contributor

@Fristi Fristi commented Sep 4, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 4, 2016

Current coverage is 91.74% (diff: 100%)

Merging #1354 into master will increase coverage by <.01%

@@             master      #1354   diff @@
==========================================
  Files           237        237          
  Lines          3571       3573     +2   
  Methods        3505       3507     +2   
  Messages          0          0          
  Branches         65         65          
==========================================
+ Hits           3276       3278     +2   
  Misses          295        295          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 7fc9d9c...4ff06d4

@adelbertc
Copy link
Contributor

👍

@kailuowang
Copy link
Contributor

I am curious why not testing SerializableTests here. ( I noticed that we are not SerializableTest BiFunctor , which I am not sure why either. )

@Fristi
Copy link
Contributor Author

Fristi commented Sep 5, 2016

I'll add those in the next commit!

@non
Copy link
Contributor

non commented Sep 5, 2016

Thanks! 👍

@non non merged commit ae51ce5 into typelevel:master Sep 5, 2016
@Fristi Fristi deleted the fristi/add-ior-monoid branch September 5, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants