-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More instances for prod #1402
Merged
Merged
More instances for prod #1402
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
64c74fa
add Monad instance for cats.data.Prod
pepegar 78f4c60
add missing implicit
pepegar c2c7e97
create instances for Foldable and Traverse
pepegar 95aed3a
create instance for MonadCombine
pepegar d648c88
create instances for Show and Order
pepegar 2032ce0
check OrderLaws for Prod
pepegar f8462cd
clean up Prod.scala file
pepegar 4e9c489
make Order have more priority than Eq
pepegar 000a583
reorder Prod instances acording to its specificity
pepegar 405dd93
simplify test("show")
pepegar 867b2a2
reorder instances to allow ambiguous implicit values
pepegar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case, to ensure the more specific instance having the highest priority, we basically want to ensure that instances of typeclasses who are lower in the inheritance tree are also lower in the instance trait inheritance tree. For example,
Monad
inheritsFunctor
and thus is more "specific" thanFunctor
, so it should be in an instance trait with higher priority (0 - 3) than whereFunctor
is (4).So, we need to rearrange the instances to that order.
MonadCombine
<:Altenative
MonadCombine
<:Monad
<:Applicative
<:Apply
<:Functor
Traverse
<:Foldable
Traverse
<:Functor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, I didn't think on that!
I've done the changes in 000a583