add a favicon for sbt-microsite #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #1530 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 246 246
Lines 3764 3764
Branches 126 125 -1
=======================================
Hits 3473 3473
Misses 291 291Continue to review full report at Codecov.
|
|
👍 |
|
Fun fact: this is my first pull request to Cats. late to the party |
|
Now you are on the contributor list :) |
|
Success!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is a hardcoded path to a favicon in sbt-microsite, which is currently a broken link.
With this link, users browsing the Cats page should hopefully see a 🐱 in the tab bar.