Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from CrossVersion.full to CrossVersion.patch for TLS compatibi… #1541

Merged
merged 2 commits into from
Feb 22, 2017

Conversation

milessabin
Copy link
Member

…lity.

To use Typelevel Scala versions which are not exactly aligned with the corresponding Lightbend Scala version (ie. because they include and additional -bin-patch-nnn suffix in their version) we need to modify project builds which use CrossVersion.full (which includes the suffix) to use CrossVersion.patch (which doesn't) where appropriate (eg. for macro-paradise and other compiler plugins).

See typelevel/scala#135

@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

Merging #1541 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1541   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         246      246           
  Lines        3764     3764           
  Branches      125      125           
=======================================
  Hits         3473     3473           
  Misses        291      291

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7919a30...d1dbd2c. Read the comment docs.

@johnynek
Copy link
Contributor

👍

1 similar comment
@kailuowang
Copy link
Contributor

👍

@kailuowang kailuowang merged commit 93a4bd0 into typelevel:master Feb 22, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants