Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #1591

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Conversation

peterneyens
Copy link
Collaborator

Improve test coverage a bit.

@codecov-io
Copy link

codecov-io commented Apr 6, 2017

Codecov Report

Merging #1591 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
+ Coverage   92.52%   93.05%   +0.52%     
==========================================
  Files         249      249              
  Lines        3974     3973       -1     
  Branches      131      131              
==========================================
+ Hits         3677     3697      +20     
+ Misses        297      276      -21
Impacted Files Coverage Δ
core/src/main/scala/cats/data/EitherT.scala 96.19% <100%> (+2.79%) ⬆️
core/src/main/scala/cats/data/Tuple2K.scala 100% <0%> (+3.33%) ⬆️
core/src/main/scala/cats/data/Nested.scala 100% <0%> (+3.84%) ⬆️
core/src/main/scala/cats/data/Const.scala 100% <0%> (+6.97%) ⬆️
core/src/main/scala/cats/Applicative.scala 83.33% <0%> (+8.33%) ⬆️
core/src/main/scala/cats/instances/try.scala 96.29% <0%> (+11.11%) ⬆️
core/src/main/scala/cats/instances/future.scala 76.47% <0%> (+11.76%) ⬆️
core/src/main/scala/cats/Apply.scala 88.88% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1601570...c4fb5e6. Read the comment docs.

import cats.laws.{ApplicativeLaws, CoflatMapLaws, FlatMapLaws, MonadLaws}
import cats.laws.discipline._
import cats.laws.discipline.arbitrary._


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this accidental or intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By accident. Fixed it, thanks.

@ceedubs
Copy link
Contributor

ceedubs commented Apr 7, 2017

👍 very nice!

@kailuowang kailuowang merged commit 62af31f into typelevel:master Apr 7, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants