-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to sbt 1.0 #1919
update to sbt 1.0 #1919
Conversation
project/build.properties
Outdated
@@ -1 +1 @@ | |||
sbt.version=0.13.16 | |||
sbt.version=1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 1.0.1 :)
Codecov Report
@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 328 328
Lines 5533 5533
Branches 199 199
=======================================
Hits 5238 5238
Misses 295 295 Continue to review full report at Codecov.
|
The 2.10 build failed with
because tut 0.6.0 is not available for 2.10. This has already been fixed in tut 0.6.1 (see tpolecat/tut#180). So sbt-microsites needs to depend on tut 0.6.1 instead of 0.6.0. |
I see that Coursier 1.0.0-RC12 has already been released with a fix for the patch issue. @kailuowang should we try that out instead of disabling Coursier? |
👍 I'm okay with merging this right now, but I think sbt/sbt#3427 means that we won't be able to publish for 2.13.0-M2 (see #1648) with this sbt version. /cc @BennyHill |
@ceedubs shall we merge this for now? the effort to support 2.13.0-M2 is put on hold right now. |
sbt 1.0 is unusably slow on MacOS because there is no native file watcher, so I would prefer to wait on this until they have a fix for that issue (which I can't find). I upgraded doobie and immediately reverted it for this reason. |
blocked due to slowness of sbt 1.0 on MacOS |
The sbt issue is sbt/sbt#3527 … now seen on Arch apparently. |
unblocked since sbt 1.0.3 reverted back to polling mode by default for MacOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
fixes #1848
I had to disable coursierit's giving meUpdate: Coursier fixed.