-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporarily disable MiMa check on kernel #1925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 248 248
Lines 4430 4430
Branches 117 116 -1
=======================================
Hits 4233 4233
Misses 197 197 Continue to review full report at Codecov.
|
can we not totally disable, and instead as people to add exceptions? This prevents us from going hog-wild breaking things. You can find notes: |
ah, then it probably makes more sense for those two PRs to add their own exceptions. I am going to add the exception for the |
yeah, I think each PR should add its own exception. |
updated. @johnynek |
👍 This is great! |
@LukaJCB do yo mind take a quick look at this one? would be nice to merge so other PRs can follow example without conflicts in the build.sbt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge expert in this field, but it looks good to me!
temporarily disable to allow a couple of approved PRs (#1712 #1527) to pass build, should reenable after 1.0.0-RC1.
Also added
QueueInstances
andDurationInstances
toall
imports