Fix order of comparison for EitherT.cond #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
approved these changes
Oct 31, 2017
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 301 301
Lines 4922 4922
Branches 123 123
=======================================
Hits 4688 4688
Misses 234 234Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very minor, but the order of the comparison for the
EitherT.condtest is swapped: if the test ever winds up catching a breaking change, it will output the incorrect "expected" value.This fixes the order and also adjusts the test name to describe what's being checked.