Add Ior.fromEither
#2057
Merged
Add Ior.fromEither
#2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaJCB
reviewed
Dec 1, 2017
| * Create an `Ior` from an `Either`. | ||
| * @param eab an `Either` from which the `Ior` should be created | ||
| * | ||
| * @return [[Ior.Left]] if the `Either` was a `Left`, |
There was a problem hiding this comment.
You have a whitespace error here :)
There was a problem hiding this comment.
Nice that cats checks for them!
markus1189
force-pushed
the
ior-fromeither
branch
from
19dfa59
to
7a2fb65
Compare
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 311 311
Lines 5270 5270
Branches 133 132 -1
=======================================
Hits 5004 5004
Misses 266 266
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Dec 1, 2017
LukaJCB
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
Ior.fromEithermethod. I am aware that there is atoIorprovided viaEitherOps, but this one is harder to find for newcomers (IMHO :D) and needs the import of theEitherSyntax.So I added the
Ior.fromEitherwhich does not require any import and is easily discoverable on theIorcompanion.24 Pull Requests (https://24pullrequests.com)