Use portable-scala crossProject #2323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2323 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 343 343
Lines 5931 5931
Branches 217 217
=======================================
Hits 5639 5639
Misses 292 292Continue to review full report at Codecov.
|
build.sbt
Outdated
| override def transform(node: xml.Node): Seq[xml.Node] = node match { | ||
| case e: xml.Elem | ||
| if e.label == "dependency" && e.child.exists(child => child.label == "groupId" && child.text == "com.github.mpilquist") => Nil | ||
| case _ => Seq(node) |
There was a problem hiding this comment.
Is this blanket removing every dependencies under "com.github.mpilquist" for the sake of simulacrum. Is this worthwhile than just using Provided?
There was a problem hiding this comment.
it just removes the simulacrum dependency the POM, a known concern, as done in the past elsewhere- eg typelevel/cats-effect#77 (comment) .
But if you would rather a more fine controlled selection, by artifact name, sure-np
There was a problem hiding this comment.
yeah, I think artifact name would be better, but if it's trickier than group name I'd vote for just leave it as "Provdided", not ideal, but didn't cause any problems in the past before we switched to the CompileTime hack.
|
Thanks @BennyHill ! |
ghost
mentioned this pull request
|
Any updates on this, please? As others are right now, just trying to cross things off my open list. |
|
Blimey....fast response!! Many thanks! |
|
Merged into 1.2.x branch which will be merged into master soon (supposedly every commits to 1.2.x should be automatically merge back to master, I just want to avoid creating too many PRs, we are going to deal with this 2 branch situation until we get a 2.13-M4 build released) |
|
Just fyi, this was originally done for the 2.13.0-m4 work, see #2267 (comment) . Looks like it is not actually required for that, so can be merged in as you require |
* remove 2.13 for releases * Setting version to 1.2.0 * Setting version to 1.2.1-SNAPSHOT * post release update * Use portable-scala crossProject (#2323) * Use portable-scala crossProject * Refine POM match for simulacrum * Drop 2.10 support / update to 2.13-M4 (#2306) * drop 2.10 support from the build * drop Scala 2.10 /update to 2.13-M3
Also added native to the kernel project, just to get the ball rolling there - ref #1549
There was an issue with issue with the workaround used by simulacrum. However, and with reference to #2152, I switched it back to
Providedand then added a post process step to remove from the POM: so hopefully, that is now OK, too.