Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OptionOps.toInvalidNec and OptionOps.toValidNec #2555

Merged

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Oct 9, 2018

We do have toInvalidNel and toValidNel already - just the the methods to lift an Option to a ValidatedNec are missing - though they come in very handy sometimes.

Complements the work already done #2475 and #2539.

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #2555 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2555      +/-   ##
=========================================
+ Coverage    95.2%   95.2%   +<.01%     
=========================================
  Files         361     361              
  Lines        6584    6586       +2     
  Branches      282     282              
=========================================
+ Hits         6268    6270       +2     
  Misses        316     316
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/option.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c56c4b...1942073. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! :)

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ybasket!

@ceedubs ceedubs merged commit 191fae4 into typelevel:master Oct 14, 2018
@ybasket ybasket deleted the add-nonemptychain-to-optionops branch October 14, 2018 16:59
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants