Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3059: Move Parallel instances into instance packages for the type constructors they characterize #3099

Merged
merged 3 commits into from
Oct 7, 2019

Conversation

barambani
Copy link
Contributor

Addresses #3059 .

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #3099 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3099      +/-   ##
==========================================
- Coverage   93.49%   93.49%   -0.01%     
==========================================
  Files         368      368              
  Lines        6983     6998      +15     
  Branches      195      198       +3     
==========================================
+ Hits         6529     6543      +14     
- Misses        454      455       +1
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/vector.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/list.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/either.scala 100% <100%> (ø) ⬆️
testkit/src/main/scala/cats/tests/Helpers.scala 96% <0%> (-4%) ⬇️
...cala/cats/kernel/instances/FunctionInstances.scala 96.96% <0%> (-3.04%) ⬇️
core/src/main/scala/cats/data/WriterT.scala 91.26% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 98.52% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/semigroup.scala 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befc276...7fb3f67. Read the comment docs.

@kailuowang
Copy link
Contributor

thanks very much! looks good to me except one nitpick, I think all the deprecation version should be 2.1.0

@barambani
Copy link
Contributor Author

good point, I'll change them. Thanks.

@kailuowang kailuowang merged commit dc44c3b into typelevel:master Oct 7, 2019
@barambani barambani deleted the issue-3059 branch October 7, 2019 21:57
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
gagandeepkalra added a commit to gagandeepkalra/cats that referenced this pull request Jan 12, 2020
djspiewak added a commit that referenced this pull request Feb 4, 2020
…ParallelInstances

Backport #3099 to scala_2.11 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants