Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clean up. Removed duplication. #3135

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Minor clean up. Removed duplication. #3135

merged 1 commit into from
Nov 11, 2019

Conversation

barambani
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 9, 2019 •
edited
Loading

Codecov Report

Merging #3135 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3135     +/-   ##
========================================
+ Coverage    93.2%   93.3%   +0.1%     
========================================
  Files         376     376             
  Lines        7324    7316      -8     
  Branches      186     181      -5     
========================================
  Hits         6826    6826             
+ Misses        498     490      -8
Flag Coverage Δ
#scala_version_212 93.63% <0%> (+0.1%) ⬆️
#scala_version_213 90.96% <0%> (+0.11%) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/parallel.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6580b...be5b7f4. Read the comment docs.

LukaJCB
LukaJCB approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@travisbrown travisbrown self-requested a review November 11, 2019 08:17
travisbrown
travisbrown approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@LukaJCB LukaJCB merged commit 624b38f into typelevel:master Nov 11, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 12, 2019
travisbrown pushed a commit to travisbrown/cats that referenced this pull request Nov 13, 2019
@travisbrown
Minor clean up (typelevel#3135)
aa3427d
This was referenced Nov 13, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@travisbrown travisbrown travisbrown approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@barambani @codecov-io @travisbrown @LukaJCB