Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #3181

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fix typo #3181

merged 1 commit into from
Dec 3, 2019

Conversation

msinton
Copy link
Contributor

@msinton msinton commented Dec 1, 2019

nextBoolean correctly implemented initially, then second occurrence would be false biased (ever so slightly!)

Thank you for contributing to Cats!

This is a kind reminder to run sbt +prePR and commit the changed files, if any, before submitting.

nextBoolean correctly implemented initially, then second occurrence would be false biased (ever so slightly!)
@codecov-io
Copy link

Codecov Report

Merging #3181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3181   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         376      376           
  Lines        7381     7381           
  Branches      195      201    +6     
=======================================
  Hits         6864     6864           
  Misses        517      517
Flag Coverage Δ
#scala_version_212 93.31% <ø> (-0.02%) ⬇️
#scala_version_213 90.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ff6fe...bda5596. Read the comment docs.

@travisbrown travisbrown self-requested a review December 3, 2019 15:38
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@LukaJCB LukaJCB merged commit b3bc539 into typelevel:master Dec 3, 2019
@msinton
Copy link
Contributor Author

msinton commented Dec 4, 2019

Thanks for catching this!

You're welcome. Thanks for Cats! I hope I can make more significant contributions in future!

@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants