Enable breakout in Reducible[NonEmptyVector].reduceMapA #3549
+34
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayahilton
changed the title
takayahilton
commented
Aug 4, 2020
| @@ -16,22 +16,6 @@ import org.scalacheck.Prop._ | |||
|
|
|||
| class ReducibleSuiteAdditional extends CatsSuite { | |||
|
|
|||
| test("Reducible[NonEmptyList].reduceLeftM stack safety") { | |||
There was a problem hiding this comment.
duplicated test
test(s"Reducible[$name].reduceLeftM stack safety")
takayahilton
force-pushed
the
fix-nonemptyc-reduceMapA
branch
2 times, most recently
from
bed5e66
to
5ecb2c5
Compare
|
Nice test refactoring. It discovered another possible improvement. I think you can change also here todef reduceRightTo[A, B](fa: NonEmptyLazyList[A])(f: A => B)(g: (A, cats.Eval[B]) => cats.Eval[B]): cats.Eval[B] =
Eval.defer(fa.reduceRightTo(a => Eval.later(f(a))) { (a, b) =>
Eval.defer(g(a, b))
}) |
barambani
reviewed
Aug 4, 2020
| @@ -484,7 +484,7 @@ sealed abstract private[data] class NonEmptyLazyListInstances extends NonEmptyLa | |||
| def reduceLeftTo[A, B](fa: NonEmptyLazyList[A])(f: A => B)(g: (B, A) => B): B = fa.reduceLeftTo(f)(g) | |||
|
|
|||
| def reduceRightTo[A, B](fa: NonEmptyLazyList[A])(f: A => B)(g: (A, cats.Eval[B]) => cats.Eval[B]): cats.Eval[B] = | |||
| Eval.defer(fa.reduceRightTo(a => Eval.now(f(a))) { (a, b) => | |||
| Eval.defer(fa.reduceRightTo(a => Eval.defer(f(a))) { (a, b) => | |||
There was a problem hiding this comment.
Suggested change
| Eval.defer(fa.reduceRightTo(a => Eval.defer(f(a))) { (a, b) => | |
| Eval.defer(fa.reduceRightTo(a => Eval.later(f(a))) { (a, b) => |
takayahilton
force-pushed
the
fix-nonemptyc-reduceMapA
branch
2 times, most recently
from
5fb1f4a
to
3df95de
Compare
Codecov Report
@@ Coverage Diff @@
## master #3549 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 386 386
Lines 8565 8565
Branches 255 248 -7
=======================================
Hits 7820 7820
Misses 745 745 |
takayahilton
force-pushed
the
fix-nonemptyc-reduceMapA
branch
2 times, most recently
from
4115b94
to
0ac03a6
Compare
barambani
previously approved these changes
Aug 5, 2020
.jvmopts
Outdated
| @@ -1,6 +1,6 @@ | |||
| -Dfile.encoding=UTF8 | |||
| -Xms1G | |||
| -Xmx5G | |||
| -Xmx6G | |||
There was a problem hiding this comment.
Is this required by the JS build ? I'm asking as if that's the case we might have a look at how those builds go when this #3546 is in. We might not need this increase anymore. What do you think ?
There was a problem hiding this comment.
We might not need this increase anymore. What do you think ?
Indeed.
#3546 is already merged so remove this commit.
takayahilton
force-pushed
the
fix-nonemptyc-reduceMapA
branch
from
951cb74
to
b77952b
Compare
LukaJCB
approved these changes
Aug 6, 2020
barambani
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.