Remove unused type parameter in Choice typeclass doc #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
edit
Whoops, this looks great. I previous incorrectly said the below but this is just docs.
I approve but this will be binary compatible but source incompatible.
The compiler will catch it for people and it is very easy to fix. Also I bet Choice is very rarely implemented. So given all this, I'm on the side of merge.
|
@johnynek This is just docs :) |
armanbilge
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
choicefunction in theChoicetypeclass documentation has an unused/unnecessary type parameterD.