Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up benchmarks' dependencies #4355

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Clean up benchmarks' dependencies #4355

merged 1 commit into from
Dec 4, 2022

Conversation

danicheg
Copy link
Member

@danicheg danicheg commented Dec 4, 2022 •
edited by armanbilge
Loading

It's been 6+ years since these benchmarks were added. They are seemingly outdated nowadays. More context #4354 (review).

Closes #4354.

armanbilge
armanbilge approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Dec 4, 2022
@danicheg danicheg merged commit b036fb4 into typelevel:main Dec 4, 2022
@danicheg danicheg deleted the clean-up-benchmarks branch December 4, 2022 21:01
imgbot bot pushed a commit to NOUIY/cats that referenced this pull request Jan 4, 2023
@danicheg
Merge pull request typelevel#4355 from danicheg/clean-up-benchmarks
2d3aaf9 
Clean up benchmarks' dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
behind-the-scenes appreciated, but not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danicheg @armanbilge