Improve stack consumption of Eval.Call
#769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the awesome speed boost for
Eval
introduced byEval.Call
has broken the stack-safety ofEval.defer
and that this is the reason that theFoldableTestsAdditional
suite is failing now and then.I have tried to reduce the stack consumption of
Eval.Call
by forcing thunks in such a way that the compiler can eliminate most of the stack.