Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ScalaCheck to 1.13.0 #17

Merged
merged 1 commit into from
Apr 10, 2016
Merged

Bump ScalaCheck to 1.13.0 #17

merged 1 commit into from
Apr 10, 2016

Conversation

adelbertc
Copy link
Contributor

Probably pending a non-SNAPSHOT release for scalatest/scalatest#837

@adelbertc adelbertc mentioned this pull request Mar 23, 2016
Closed
@larsrh
Copy link
Contributor

larsrh commented Mar 23, 2016

There appears to be some version clash with Scala.js. Unfortunately I have no idea what to do about that 😦

@non
Copy link

non commented Mar 23, 2016

Yeah I have ran into this too. I wonder if @bvenners has seen it?

@adelbertc adelbertc mentioned this pull request Mar 23, 2016
Closed
@adelbertc
Copy link
Contributor Author

Could it be related to not having a published JS SNAPSHOT for that milestone? scalatest/scalatest#837 (comment)

@adelbertc adelbertc mentioned this pull request Mar 23, 2016
Closed
@adelbertc
Copy link
Contributor Author

OK I lied, he does have JS SNAPSHOT published: scalatest/scalatest#837 (comment)

On a related note, are we OK with depending on a SNAP (a stable SNAPSHOT) release, or would we like to wait for a more final release?

On a more selfish note, this decision impacts how quickly we can fix the Cats build.

@adelbertc
Copy link
Contributor Author

Seems it was just an incompatible version of Scala.JS. Fixed now.

@larsrh larsrh merged commit b73f3c2 into typelevel:master Apr 10, 2016
@larsrh
Copy link
Contributor

larsrh commented Apr 10, 2016

Thanks, merged!

@adelbertc
Copy link
Contributor Author

Sweet - what's the roadmap looking like for the next release?

@larsrh
Copy link
Contributor

larsrh commented Apr 11, 2016

I could either wait for #18 or cut one now, what would you prefer?

@adelbertc
Copy link
Contributor Author

@larsrh Let's wait, I'll try to ping/PR again when ScalaTest makes a non-SNAP release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelbertc @larsrh @non