Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: rename LambdaEnv -> Invocation #427

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Nov 21, 2023

I think "invocation" is a more suitable:

  • the event and context are relevant only during a specific invocation of the lambda function
  • "env" is reminiscent of environment variables that have a different lifecycle. Also the concept became overloaded in our custom lambda runtime which is less than ideal.

I left deprecated aliases in place. Should be a pretty easy find-replace for downstreams.

@fredshonorio
Copy link
Contributor

fredshonorio commented Nov 21, 2023

Having superficial experience with aws lambda (before feral existed) I like the new name better.

@bpholt
Copy link
Member

bpholt commented Nov 21, 2023

Seems reasonable. Could we provide a Scalafix for the rewrite?

@armanbilge
Copy link
Member Author

armanbilge commented Nov 21, 2023

Could we provide a Scalafix for the rewrite?

Let me look into that :)

Update: this is a really great example!
typelevel/catbird@7992250

@armanbilge
Copy link
Member Author

Will do a follow-up PR with scalafixes for this and some other changes. Thanks everyone!

@armanbilge armanbilge merged commit 5566409 into typelevel:main Nov 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants