Call Subscriber.onSubscribe(StreamSubscription) before returning from StreamPublisher.subscribe(Subscriber)
#3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… StreamPublisher.subscribe(Subscriber)
BalmungSan
commented
Dec 13, 2023
Comment on lines
176
to
180
| // SIDE-EFFECTING! | ||
| // We need this constructor to don't be wrapped on F, | ||
| // Because some consumers expect we call Subscriber.onSubscribe(StreamSubscription) | ||
| // Before returning from StreamPublisher.subscribe(Subscriber) | ||
| // See https://github.com/typelevel/fs2/issues/3359 |
There was a problem hiding this comment.
Feedback or better wording is welcome :)
armanbilge
approved these changes
Dec 14, 2023
armanbilge
changed the title
Subscriber.onSubscribe(StreamSubscription) before returning from StreamPublisher.subscribe(Subscriber)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3359 ?
c.c. @armanbilge as always I couldn't resit and made some renames along the way, sorry 😅