Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Monoid derivation and add more tests #132

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

joroKr21
Copy link
Member

  • Drop the "algebraic" definition, the boilerplate is minimal
  • Make it more consistent with the rest of the derivations
  • Add tests for all three variants of derivation
  • Add a test for existing instances
  • Add Lazy where necessary to make sure recursive cases work
  • Refactor test class definitions a bit

 * Drop the "algebraic" definition, the boilerplate is minimal
 * Make it more consistent with the rest of the derivations
 * Add tests for all three variants of derivation
 * Add a test for existing instances
 * Add `Lazy` where necessary to make sure recursive cases work
 * Refactor test class definitions a bit
@joroKr21 joroKr21 self-assigned this Apr 21, 2019
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks!

@joroKr21 joroKr21 merged commit 0fc7b3b into typelevel:master Apr 22, 2019
@joroKr21 joroKr21 deleted the monoid branch April 26, 2019 12:37
@kailuowang kailuowang added this to the 2.0.0-M1 milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants