Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Functor derivation #140

Merged
merged 1 commit into from
May 1, 2019
Merged

Rework Functor derivation #140

merged 1 commit into from
May 1, 2019

Conversation

joroKr21
Copy link
Member

  • Make it more consistent with other derivations
  • Make sure it's stack safe
  • Add more tests

Based on #138

@joroKr21 joroKr21 added this to the 2.0.0-RC1 milestone Apr 27, 2019
@joroKr21 joroKr21 self-assigned this Apr 27, 2019
@joroKr21 joroKr21 force-pushed the functor branch 3 times, most recently from 5bd3bf9 to c21116e Compare April 29, 2019 23:29
@joroKr21
Rework Functor derivation
e5099fd 
* Make it more consistent with other derivations
* Make sure it's stack safe
* Add more tests
@joroKr21 joroKr21 mentioned this pull request May 1, 2019
Closed
18 tasks
kailuowang
kailuowang approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joroKr21 joroKr21 merged commit 2b62a18 into typelevel:master May 1, 2019
@joroKr21 joroKr21 deleted the functor branch May 1, 2019 20:28
@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M1 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

Assignees

@joroKr21 joroKr21

Labels
Design/refactoring
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@joroKr21 @kailuowang