Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Pure derivation #151

Merged
merged 1 commit into from
May 29, 2019
Merged

Rework Pure derivation #151

merged 1 commit into from
May 29, 2019

Conversation

joroKr21
Copy link
Member

  • Make it more consistent with other derivations
  • Add more tests
  • Drop Coproduct derivation (no way to ensure uniqueness)

@joroKr21
Rework Pure derivation
d7ca4ab 
 * Make it more consistent with other derivations
 * Add more tests
 * Drop Coproduct derivation (no way to ensure uniqueness)
@joroKr21 joroKr21 added this to the 2.0.0-RC1 milestone May 28, 2019
@joroKr21 joroKr21 requested a review from kailuowang May 28, 2019 21:31
@joroKr21 joroKr21 self-assigned this May 28, 2019
kailuowang
kailuowang approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joroKr21 joroKr21 merged commit 036cfda into typelevel:master May 29, 2019
This was referenced May 29, 2019
Closed
Closed
Closed
@joroKr21 joroKr21 deleted the pure branch May 29, 2019 04:41
@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M1 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

Assignees

@joroKr21 joroKr21

Labels
Design/refactoring
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@joroKr21 @kailuowang