Structure Hierarchy and Structured Logger Modification Function #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,4 +10,13 @@ trait StructuredLogger[F[_]] extends Logger[F] { | |||
|
|
|||
| object StructuredLogger{ | |||
| def apply[F[_]](implicit ev: StructuredLogger[F]): StructuredLogger[F] = ev | |||
|
|
|||
| def withContext[F[_]](sl: StructuredLogger[F])(ctx: (String, String)*): MessageLogger[F] = | |||
There was a problem hiding this comment.
Is this function worth this shift? Even if primarily invisible to the user.
|
I like this proposal, and it opens up new avenues of combining stuff. For instance: why couldn't (wouldn't) we have a similar |
|
Alright, I think after we merge this it may be appropriate to start with some binary compatible versions as presently this seems sufficiently stable for most purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a way of dealing with #44, so now we have a concrete solution.