-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tuple syntax #248
Add tuple syntax #248
Conversation
Thats cool! I always liked I have one future-oriented query. Scala 3 is released and gradually the community will migrate to it. The implementation of |
@benhutchison thanks for the review! I have pondered about |
@benhutchison PR in dotty was merged, so I've changed tuple syntax to be available only for Scala 2. |
af73af4
to
b774201
Compare
@danicheg apology for slows, I like the plan to make avail in 2.12 only and your PR to core 👏 |
48e87a9
to
7af8429
Compare
@benhutchison sorry for yet another ping. I have ended up working on this and would be extremely glad for your review. |
This PR brings 4 handy methods for tuples (for Scala 2 only):
That functionality there is in
shapeless
https://github.com/milessabin/shapeless/blob/main/core/src/main/scala/shapeless/syntax/std/tuples.scala#L30. However, bringingshapeless
as a dependency just for tuple syntax is overkill, I think. What's more, implementation inmouse
is plain and not used type-level magic, so it will not affect compile time at all.