Add mapOrKeepIn / flatMapOrKeepIn to F[Option[A]] and F[Either[A,B]] syntaxes
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @benhutchison, no hurry at all, just mentioning you to make this PR more visible for review. Thanks! |
|
Alright. Changes are isolated, and it's merely four auxiliary methods affecting a few syntaxes. So, I'm merging this and will wait a week before releasing it to see if anyone expresses interest in propagating any related changes. |
|
Apologies for missing this @danicheg 🙏 I need to de-noise my inbox so I don't miss these. |
|
@benhutchison No worries, you owe nothing! It's FOSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are counterpart methods to newly shipped
Functor#mapOrKeepandMonad#flatMapOrKeepmethods in Cats. From my tastes,mapOrKeepInmight be highly useful whileflatMapOrKeepInis not as much as the former. But I still decided to add it too and have complete conformity with Cats.