Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk-trace: rename LoggingSpanExporter to ConsoleSpanExporter #651

Merged
merged 1 commit into from
May 1, 2024
Merged

sdk-trace: rename LoggingSpanExporter to ConsoleSpanExporter #651

merged 1 commit into from
May 1, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Apr 26, 2024 •
edited
Loading

The logging exporter name has been deprecated since v1.28.0 (2023-12-07). The actual spec:

"logging" - It is a deprecated value left for backwards compatibility. It SHOULD
NOT be supported by new implementations.

The sdk-metrics module already uses a correct name.

Making the sdk-trace module up to date too.

@iRevive iRevive added tracing Improvements to tracing module sdk module Features and improvements to the sdk module labels Apr 26, 2024
@iRevive iRevive requested a review from NthPortal April 26, 2024 10:26
@iRevive iRevive merged commit 00f9418 into typelevel:main May 1, 2024
10 checks passed
@iRevive iRevive deleted the sdk-trace/rename-logging-exporter branch May 1, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NthPortal NthPortal NthPortal approved these changes

Assignees
No one assigned
Labels
sdk module Features and improvements to the sdk module tracing Improvements to tracing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iRevive @NthPortal