core-trace: use ExitCase to build attributes in Histogram#recordDuration
#761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
approved these changes
Sep 9, 2024
...java/metrics/src/main/scala/org/typelevel/otel4s/oteljava/metrics/HistogramBuilderImpl.scala
Outdated
Show resolved
Hide resolved
iRevive
force-pushed
the
core-trace/histogram-record
branch
from
173be99
to
0c6d45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also a major behavior change:
recordDurationno longer addscauseattribute by default.To preserve old behavior, users must use
histogram.recordDuration(TimeUnit.SECONDS, Histogram.recordCause).Motivation
causeattribute is opinionated and doesn't go along with most of the semantic conventions.In most conventions, it would be error.type instead.