-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project housekeeping #632
Project housekeeping #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for taking the time to do this. I really appreciate it.
mimaBinaryIssueFilters ++= { | ||
if (tlIsScala3.value) { | ||
import com.typesafe.tools.mima.core._ | ||
Seq( | ||
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.typelevel.paiges.Chunk*") | ||
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.typelevel.paiges.Chunk*"), | ||
ProblemFilters.exclude[DirectMissingMethodProblem]("org.typelevel.paiges.Chunk#ChunkStream#3#Empty.this") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anyone should be coding against this. Not sure why it keeps having issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new error is possibly due to some change between Scala 3.3.0 and 3.3.3, maybe some default constructor for case objects got removed, idk.
Thanks for your offer of help. I'd very much appreciate it! Offer accepted. |
I'm glad :D I'll ask Sam to add me then. Thanks Oscar. |
👋🏻 I added Tonio to the paiges team, but I just wanted to flag that the team only has write permissions and not maintain permissions to the repo (so not able to merge PRs, currently). @johnynek am I okay to bump up the permissions there? |
@samspills sure, thank you very much! |
Hello @johnynek, I did some project housekeeping, bumping all the dependencies and the plugins to their latest version and fixed some CI issues.
This PR should theoretically handle the following issues/PRs
closes #404
closes #590
closes #615
closes #618
closes #627
closes #625
closes #624
closes #623
closes #622
closes #621
closes #612
closes #609
closes #599
Also, since you're the only maintainer atm, I offer my help to house keep the project, basically to merge Scala Steward PRs and release whenever it's necessary, so that we can split the effort in two. WDYT?
Last but not least, a paiges release compatible with Scala Native 0.5.x is required to unlock
scalameta/metaconfig
as it depends on this.Tagging @ekrich for reference.
P.s. I ask you to pay attention to the mima exclusion I added in the build, I'm not 100% sure that's the correct way to go. Cheers!