Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tlPrePrBotHook #111

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Conversation

armanbilge
Copy link
Member

Another prePR-style alias, but this one skips the clean compile and is intended only for bots. Since sbt-typelevel absorbs so many plugins (sbt-gh-actions, sbt-scalafmt, etc.) this command will provide a unified way for scala-steward to run all the necessary post-upgrade steps. Will also be useful for #69 and any other ideas we come up with that require sbt-typelevel-managed files.

@armanbilge armanbilge changed the base branch from main to series/0.4 January 28, 2022 16:09
@rossabaker
Copy link
Member

Is Scala Steward going to know about this?

@armanbilge
Copy link
Member Author

Yep, that's the plan. This way we can update what's in this hook—and downstream plugins can even add additional steps—without steward itself needing to be adjusted.

@rossabaker
Copy link
Member

So for example http4s could add its scalafix lints. Yeah, this seems reasonable, if Scala Steward is going to integrate with it.

@armanbilge
Copy link
Member Author

The parallel PR to steward was merged :)

@armanbilge armanbilge merged commit f240d64 into typelevel:series/0.4 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants