Accommodate user-defined mirrors #219
Conversation
modules/deriving/src/main/scala/shapeless3/deriving/kinds.scala
Outdated
Show resolved
Hide resolved
modules/deriving/src/main/scala/shapeless3/deriving/kinds.scala
Outdated
Show resolved
Hide resolved
modules/deriving/src/test/scala/shapeless3/deriving/deriving.scala
Outdated
Show resolved
Hide resolved
modules/deriving/src/main/scala/shapeless3/deriving/kinds.scala
Outdated
Show resolved
Hide resolved
joroKr21
force-pushed
the
ud-mirrors
branch
4 times, most recently
from
f461a2d
to
be4bc43
Compare
|
@tschuchortdev I tried this out in Kittens and unfortunately it degrades compiler performance significantly ( |
|
Oh, that's too bad, but I guess it can't be avoided. Have you thought about putting an |
|
Yes, this would make sense. Although I'm still waiting for a backport of |
| def assertImportSuggested(errors: List[testing.Error]): Unit = | ||
| assertEquals(1, errors.size) | ||
| val message = errors.head.message.trim | ||
| assert(message.startsWith("No given instance of type")) | ||
| assert(message.endsWith("Generic.fromMirror")) |
There was a problem hiding this comment.
@tschuchortdev the default message already suggests the import so I think it's adequate
There was a problem hiding this comment.
Alright. In my experience those suggestions are rarely productive, so I tend to ignore them.
|
Looks good to me now. |
Fixes #218