Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make temporal codecs immune to locale #232

Merged
merged 1 commit into from
Aug 4, 2020
Merged

make temporal codecs immune to locale #232

merged 1 commit into from
Aug 4, 2020

Conversation

tpolecat
Copy link
Member

@tpolecat tpolecat commented Aug 4, 2020

A user discovered that temporal codecs with an era as part of their format don't work in some locales (es_CO specifically but there are likely others). This fixes the locale to Locale.US in the DateTimeFormatters used by the codecs, which should be ok because we're fixing the date style to ISO, MDY during session startup and have declared in the doc that if you change it you're in trouble.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #232 into master will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   83.56%   84.01%   +0.44%     
==========================================
  Files         107      107              
  Lines        1229     1251      +22     
  Branches       16       22       +6     
==========================================
+ Hits         1027     1051      +24     
+ Misses        202      200       -2     
Impacted Files Coverage Δ
modules/core/src/main/scala/Decoder.scala 100.00% <100.00%> (ø)
...les/core/src/main/scala/codec/TemporalCodecs.scala 87.27% <100.00%> (+6.19%) ⬆️
...ore/src/main/scala/net/AbstractMessageSocket.scala 83.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075f845...8919b8a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants