make temporal codecs immune to locale #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user discovered that temporal codecs with an era as part of their format don't work in some locales (
es_CO
specifically but there are likely others). This fixes the locale toLocale.US
in theDateTimeFormatters
used by the codecs, which should be ok because we're fixing the date style toISO, MDY
during session startup and have declared in the doc that if you change it you're in trouble.