-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use munit diff logic #25
Conversation
To summarize the discussions on this, there are two approaches we could take to improving the diff logic:
I'm exploring pulling in the library dependency, but shading it such that users of weaver and munit are unaffected. Given that the lib is unlikely to change, but is on the same release cadence as munit, releases will also be excluded from Scala Steward. |
Changes look good 👍 Do you have a rough idea of when munit-diff could be released ? |
Munit and munit-diff 1.0.0-RC1 is out. I also released manually for 0.4 Scala Native. Do let me know if it works! |
Merging even if it depends on an RC, because it's shaded anyway, and because there's still a little bit of work to be done before an actual release of weaver, which may give munit enough time for a 1.0.0 release |
As part of #15 , we wish to improve the diff rendering of the
Comparison
trait by using a Myers diff implementation. munit's Myers diff algorithm is a prime candidate.As discussed on Discord, we prefer to vendor the diff logic than pull in an external dependency.
This PR is an experiment in vendoring.
Note that:
scala-diff
library is yet to be published.