-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MySQL table support comment #10017
feat: MySQL table support comment #10017
Conversation
Why do you have package-lock file changed? There is a problem with your implementation - sync doesn't work such way. If you put comment to entity - it will be stored in the database. If you change comment on the same entity later on - it won't sync the changes. We need implementation to be full-fledged before we can merge the changes. |
774084e
to
33512d2
Compare
Thanks, this is an oversight on my part, I'm not familiar with the sync, can you give me some guidance? Is it okay to modify the renameTable method of the MysqlQueryRunner class or add a new method to modify table comments separately |
@sinkhaha let's say you put comment to entity. Comment now is in database for your table. Now change comment in the entity. Syncer must "catch up" this change and update the table comment in the database. Synchronization is made by To understand how it works, play around with let's say columns -> add column, remove column from your entity -> database table will be updated. To understand how it works from the code perspective - you have to learn how |
@pleerock Thanks. I have made some changes. Please review it again when you have time. |
ci/circleci: build — Your tests failed on CircleCI Whether you have time to fix |
@yuntian001 This doesn't seem to be an error caused by my changes. Is it okay to rebuild it? I don't have permission to trigger. |
Description of change
MySQL table support comment
Fixes #9991
Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this changeFixes #0000