Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): handle optional computed prop w/o type #1026

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1019

@bradzacher bradzacher added the bug Something isn't working label Sep 30, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #1026 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   94.14%   94.14%   +<.01%     
==========================================
  Files         115      115              
  Lines        5019     5020       +1     
  Branches     1404     1405       +1     
==========================================
+ Hits         4725     4726       +1     
  Misses        166      166              
  Partials      128      128
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.96% <100%> (ø) ⬆️

@bradzacher bradzacher changed the title fix(typescript-estree): handle opt computed prop without type annotation fix(typescript-estree): handle optional computed prop w/o type Sep 30, 2019
@bradzacher bradzacher merged commit 95c13fe into master Sep 30, 2019
@bradzacher bradzacher deleted the 1019-computed-optional-prop branch September 30, 2019 16:31
@bradzacher bradzacher restored the 1019-computed-optional-prop branch September 30, 2019 16:31
@bradzacher bradzacher deleted the 1019-computed-optional-prop branch September 30, 2019 16:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"optional" does not exist on computed optional class property with variable
1 participant