feat(typescript-estree): support 3.8 export * as ns
#1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradzacher
added
enhancement
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
bradzacher
force-pushed
the
3-8-export-star-as-ns
branch
from
a56005d
to
9c33d13
Compare
bradzacher
force-pushed
the
3-8-export-star-as-ns
branch
from
9c33d13
to
ad11fb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 95.18% 95.21% +0.02%
==========================================
Files 148 148
Lines 6953 6953
Branches 2005 2006 +1
==========================================
+ Hits 6618 6620 +2
+ Misses 124 123 -1
+ Partials 211 210 -1
|
bradzacher
removed
the
blocked by another PR
bradzacher
force-pushed
the
3-8-export-star-as-ns
branch
from
ad11fb8
to
b88d929
Compare
This was referenced Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESTree representation is approved, but not yet merged.It's now merged :D
estree/estree#205