Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): support 3.8 export * as ns #1698

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Mar 7, 2020

The ESTree representation is approved, but not yet merged.
It's now merged :D
estree/estree#205

@bradzacher bradzacher added enhancement New feature or request blocked by another PR PRs which are ready to go but waiting on another PR labels Mar 7, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #1698 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
+ Coverage   95.18%   95.21%   +0.02%     
==========================================
  Files         148      148              
  Lines        6953     6953              
  Branches     2005     2006       +1     
==========================================
+ Hits         6618     6620       +2     
+ Misses        124      123       -1     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 99.15% <100.00%> (+0.28%) ⬆️

@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant