Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages #6780

Merged
merged 8 commits into from
Apr 17, 2023
Merged

fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages #6780

merged 8 commits into from
Apr 17, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Mar 27, 2023

PR Checklist

Overview

  • Added TypeOrValueSPecifier tests for package specifiers

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @marekdedic!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e97628f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/643d30c81540080008b89f90
😎 Deploy Preview https://deploy-preview-6780--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines +142 to +143
(ast.body[ast.body.length - 1] as TSESTree.TSTypeAliasDeclaration)
.id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think this fixes a minor issue that is probably present in more tests - I have taken this directly out of some other tests in this repo

@nx-cloud
Copy link

nx-cloud bot commented Mar 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e97628f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@marekdedic marekdedic changed the title fix(type-utils): fixed TypeOrValueSpecifier not accounting for org-scoped DT packages fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages Mar 27, 2023
@marekdedic marekdedic marked this pull request as ready for review March 27, 2023 21:41
@bradzacher bradzacher added the bug Something isn't working label Apr 10, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks for the fast follow! Just requesting changes on 1-2 cleanups, lmk what you think?

packages/type-utils/src/TypeOrValueSpecifier.ts Outdated Show resolved Hide resolved
packages/type-utils/src/TypeOrValueSpecifier.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #6780 (e97628f) into v6 (8a2752f) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6780      +/-   ##
==========================================
+ Coverage   87.36%   87.51%   +0.14%     
==========================================
  Files         373      376       +3     
  Lines       12800    12940     +140     
  Branches     3793     3820      +27     
==========================================
+ Hits        11183    11324     +141     
+ Misses       1232     1231       -1     
  Partials      385      385              
Flag Coverage Δ
unittest 87.51% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts 90.32% <100.00%> (+1.03%) ⬆️

... and 15 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 great, thanks!

Weird puppet saying hooray

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 17, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3350940 into typescript-eslint:v6 Apr 17, 2023
39 of 42 checks passed
@marekdedic marekdedic deleted the type-or-value-specifier-scoped-packages branch April 17, 2023 15:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants