fix(eslint-plugin): [prefer-string-starts-ends-with] only report slice/substring with correct range

[Josh-Cena]

PR Checklist

• Addresses an existing open issue: fixes [prefer-string-starts-ends-with] False positive for substring with length limit #4181
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Avoids reporting slice/substring where the sliced range does not match the expected substring's. This may lead to false negatives, but is "safe" in the general sense.

[typescript-eslint]

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	5fdbd79
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6519a9d664e02c000864b334

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5fdbd79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 20 targets

• nx test eslint-plugin --coverage=false
• nx run-many --target=lint --parallel
• nx test typescript-estree --coverage=false
• nx test scope-manager --coverage=false
• nx build website
• nx run types:build
• nx test visitor-keys --coverage=false
• nx test type-utils --coverage=false
• nx test utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run repo-tools:postinstall-script
• nx run integration-tests:test
• nx test parser --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test ast-spec --coverage=false
• nx test repo-tools --coverage=false
• nx run-many --target=typecheck --parallel
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Tricky! Nicely done 👌