Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [require-await] allow yielding Promise in async generators #8003

Merged
merged 2 commits into from Dec 5, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Nov 28, 2023

PR Checklist

Overview

I had to slightly refactor markAsHasDelegateGen:

  1. Early return from if (node.argument.type === AST_NODE_TYPES.Literal) since scopeInfo.isAsyncYield ||= false; is meaningless
  2. Now function accepts both nodes with delegate=true and delegate=false

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3a1c869
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65662b287844cb000842c75c
😎 Deploy Preview https://deploy-preview-8003--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is perfect, thanks as usual!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4c3e704 into typescript-eslint:main Dec 5, 2023
58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [require-await] add an option to ignore async generators or support yield Promise
2 participants