Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [unbound-method] exempt all non-Promise built-in statics #8096

Merged
merged 2 commits into from Dec 25, 2023
Merged

fix(eslint-plugin): [unbound-method] exempt all non-Promise built-in statics #8096

merged 2 commits into from Dec 25, 2023

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Dec 18, 2023 •
edited by JoshuaKGoldberg

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 18, 2023 •
edited

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ac0740e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6589b8f9edbee50008f98035
😎 Deploy Preview https://deploy-preview-8096--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3182959 into typescript-eslint:main Dec 25, 2023
5 of 6 checks passed
@JoshuaKGoldberg
Copy link
Member

Merging quickly to sneak this into the release today 😄

@JoshuaKGoldberg
Copy link
Member

Oh cool, I accidentallied a race condition in the release job:

lerna sill isBehindUpstream main is behind origin/main by 1 commit(s) and ahead by 0
lerna WARN EBEHIND Local branch 'main' is behind remote upstream origin/main, exiting

Will re-run.

auvred pushed a commit to auvred/typescript-eslint that referenced this pull request Dec 29, 2023
@Josh-Cena @JoshuaKGoldberg @auvred
fix(eslint-plugin): [unbound-method] exempt all non-Promise built-in …
57e9b2c 
…statics (typescript-eslint#8096)

* fix(eslint-plugin): [unbound-method] exempt all non-Promise built-in statics

* yarn format --write

---------

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [unbound-method] should not report most built-in static methods
2 participants
@Josh-Cena @JoshuaKGoldberg