Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Stylistic equivalent #8123

Merged
merged 3 commits into from Dec 25, 2023
Merged

feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Stylistic equivalent #8123

merged 3 commits into from Dec 25, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

https://eslint.style/rules/ts/no-extra-semi is the new space for that rule.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 24, 2023 •
edited

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6680520
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6588b49cee31f700082304fa
😎 Deploy Preview https://deploy-preview-8123--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher
Copy link
Member

Note that your deprecation banner doesn't show up because you gated it to just layout rules.

bradzacher
bradzacher previously approved these changes Dec 24, 2023
View reviewed changes
@JoshuaKGoldberg
Copy link
Member Author

Note that your deprecation banner doesn't show up because you gated it to just layout rules.

Ah good point. updated #8117 to include the notice if the rule is replacedBy a @stylistic/.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9368bf3 into typescript-eslint:main Dec 25, 2023
56 of 57 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the deprecate-no-extra-semi branch December 25, 2023 02:42
auvred pushed a commit to auvred/typescript-eslint that referenced this pull request Dec 29, 2023
@JoshuaKGoldberg @auvred
feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Styli…
eb16cc7 
…stic equivalent (typescript-eslint#8123)

* feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Stylistic equivalent

* generate:configs

* Fix configs generation
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move no-extra-semi into ESLint Stylistic too?
2 participants
@JoshuaKGoldberg @bradzacher