Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix more cases with double slash in JSX text #607

Merged
merged 6 commits into from
Jun 19, 2019

Conversation

duailibe
Copy link
Contributor

@duailibe duailibe commented Jun 10, 2019

This improves upon the commit 72552a3, catching more cases that needs to call rescanJsxToken(): after a closing element, after a self-closing element and after a JSX expression, when inside a JSX element.

Caught this with Prettier: prettier/prettier#6084

Fixes #606

@duailibe
Copy link
Contributor Author

PS: looks like the following files need to be formatted

CHANGELOG.md
packages/eslint-plugin-tslint/CHANGELOG.md
packages/eslint-plugin/CHANGELOG.md
packages/experimental-utils/CHANGELOG.md
packages/parser/CHANGELOG.md
packages/typescript-estree/CHANGELOG.md

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

packages/typescript-estree/tests/lib/comments.ts Outdated Show resolved Hide resolved
@duailibe
Copy link
Contributor Author

duailibe commented Jun 10, 2019

I can't make CI green.. looks like there's some cache, it's not "seeing" the latest branch state

@duailibe duailibe closed this Jun 10, 2019
@duailibe duailibe reopened this Jun 10, 2019
@duailibe
Copy link
Contributor Author

Nope, it was just me being dumb 😅

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #607 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   94.26%   94.27%   +<.01%     
==========================================
  Files         105      105              
  Lines        4345     4349       +4     
  Branches     1195     1197       +2     
==========================================
+ Hits         4096     4100       +4     
  Misses        145      145              
  Partials      104      104
Impacted Files Coverage Δ
packages/typescript-estree/src/convert-comments.ts 96.29% <100%> (+0.29%) ⬆️

@JamesHenry JamesHenry merged commit 34cfa53 into typescript-eslint:master Jun 19, 2019
@duailibe duailibe deleted the jsx-slash-text branch June 19, 2019 20:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser mishandling comments in jsx including //.
3 participants