-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): fix more cases with double slash in JSX text #607
Conversation
PS: looks like the following files need to be formatted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit
I can't make CI green.. looks like there's some cache, it's not "seeing" the latest branch state |
Nope, it was just me being dumb 😅 |
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 94.26% 94.27% +<.01%
==========================================
Files 105 105
Lines 4345 4349 +4
Branches 1195 1197 +2
==========================================
+ Hits 4096 4100 +4
Misses 145 145
Partials 104 104
|
This improves upon the commit 72552a3, catching more cases that needs to call
rescanJsxToken()
: after a closing element, after a self-closing element and after a JSX expression, when inside a JSX element.Caught this with Prettier: prettier/prettier#6084
Fixes #606