Support for Scout shouldBeSearchable #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scout's `shouldBeSearchable` function fires a delete record on all save/create events. This makes sense as Scout does not keep track if models have been added before or not. This update checks for the model's existence before attempting to delete it.
manavo
reviewed
Feb 27, 2023
| @@ -123,9 +123,14 @@ public function deleteDocument(Collection $collectionIndex, $modelId): array | |||
| /** | |||
| * @var $document Document | |||
| */ | |||
| $document = $collectionIndex->getDocuments()[(string) $modelId]; | |||
| $document = $collectionIndex->getDocuments()[(string) $modelId] ?? null; | |||
There was a problem hiding this comment.
Due to how getDocuments works, this has been problematic in the past, so we'd need to remove the ?? null (#7)
manavo
reviewed
Feb 27, 2023
|
|
||
| return $document->delete(); | ||
| // dd($document); |
There was a problem hiding this comment.
Should maybe remove the debug code?
|
Hi @BrandonJamesBorders, |
|
@arayiksmbatyan can close this PR then? |
|
@manavo Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scout's
shouldBeSearchablefunction fires a delete record on all save/create events. This makes sense as Scout does not keep track if models have been added before or not.Change Summary
This update checks for the model's existence before attempting to delete it.
PR Checklist